From ef864f61ea0ba8693e36cc3d862fdc7bb7d76ab8 Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Tue, 12 Nov 2024 19:32:33 -0300 Subject: [PATCH 1/2] doc: add notable-change mention to sec release --- doc/contributing/releases.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index 400aa51fb2667d..2f726f3f34b29b 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -311,6 +311,9 @@ $ git checkout -b v1.2.3-proposal upstream/v1.x git cherry-pick ... # cherry-pick nodejs-private PR commits directly into the proposal ``` +Remember to flag the CVE fixes as `notable-change` in the nodejs-private so it +will be automatically included in the CHANGELOG "Notable Changes" section. + ### 3. Update `src/node_version.h` From eae01e4e70acbe933d9be20618fbbbbdae440649 Mon Sep 17 00:00:00 2001 From: Rafael Gonzaga Date: Wed, 13 Nov 2024 09:45:52 -0300 Subject: [PATCH 2/2] Update doc/contributing/releases.md Co-authored-by: Antoine du Hamel --- doc/contributing/releases.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index 2f726f3f34b29b..5914d4b953bb92 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -311,8 +311,8 @@ $ git checkout -b v1.2.3-proposal upstream/v1.x git cherry-pick ... # cherry-pick nodejs-private PR commits directly into the proposal ``` -Remember to flag the CVE fixes as `notable-change` in the nodejs-private so it -will be automatically included in the CHANGELOG "Notable Changes" section. +Be sure to label the CVE fixes as `notable-change` in the nodejs-private repository. +This will ensure they are included in the "Notable Changes" section of the CHANGELOG.