Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Card Component #6033

Closed
bmuenzenmeyer opened this issue Oct 20, 2023 · 3 comments · Fixed by #6037
Closed

Create Card Component #6033

bmuenzenmeyer opened this issue Oct 20, 2023 · 3 comments · Fixed by #6037
Labels
good first issue Issues for newcomers hacktoberfest This Issue is meant for Hacktoberfest 2023 help wanted website redesign Issue/PR part of the Node.js Website Redesign

Comments

@bmuenzenmeyer
Copy link
Collaborator

Create a Card component using the figma design (direct link).

This component is a card that previews other content, usually a blog post.

Read more about the Node.js Website redesign


Before You Start...


Details

image

Not sure where to start breaking down the figma? Read this short guide

Suggested Props

Name type comments
heading string example: Node.js March 17th Infrastructure Incident Post-mortem per figma, passes through to Preview
subheading string example: Vulnerabilities per figma
type enum announcement | release | vulnerability default is announcement, passes through to Preview - this enum is already in preview - reuse it
supportingText string excerpt of post content, limited to 3 lines via line-clamp. Starting on March 15th and going through to March 17th (with much of the issue being mitigated on the 16th), users were receiving intermittent 404 responses when trying to download Node.js from nodejs.org, or even accessing parts of the website. per figma
avatars typeof Avatar[] use the alt value from Avatar as the author's full name, such as Hayden Bleasel per figma
date Date formatted as 20 Jan 2024 per figma

Storybook

Add a storybook story file components/Common/Cards/index.stories.tsx which exercises each of the compnent's states.

There are 2 states to capture within styles and stories:

  • Light
  • Dark
@bmuenzenmeyer bmuenzenmeyer added help wanted good first issue Issues for newcomers website redesign Issue/PR part of the Node.js Website Redesign hacktoberfest This Issue is meant for Hacktoberfest 2023 labels Oct 20, 2023
@bmuenzenmeyer bmuenzenmeyer moved this to 🔖 Ready in Website Redesign Oct 20, 2023
@YashM211
Copy link

Can I get this one.

@bmuenzenmeyer
Copy link
Collaborator Author

Thanks for your interest. We don't assign tickets if we can help it. Feel free to submit a pull request if you have time.
Reference 🍪 https://www.redhat.com/en/blog/dont-lick-cookie

@danielmarcano
Copy link
Contributor

Hi, @bmuenzenmeyer! Hope you are doing great. I have just created a PR with the new Common/Card component ✨

@bmuenzenmeyer bmuenzenmeyer moved this from 🔖 Ready to ✅ Done in Website Redesign Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues for newcomers hacktoberfest This Issue is meant for Hacktoberfest 2023 help wanted website redesign Issue/PR part of the Node.js Website Redesign
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants