-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Navbar
Component
#6060
Comments
Thanks for your interest. We don't assign tickets if we can help it. Feel free to submit a pull request if you have time. |
Looks like we will be using |
Is that work done? |
Please assign this to me i will do this work in 1-2 hrs |
Hey, I think you have a typo here. You probably meant to write |
yes |
is this issue still open . Can you please assign me this issue |
This issue already has an open PR which is already in review... |
Create a
Navbar
component using the new figma design (direct link).This component starts the responsive header for the new site.
Before You Start...
Details
❓ Not sure where to start breaking down the figma? Read this short guide
🌐 This story requires some internationalization support. Slow down!
Navbar
within thesections
directory that contains all the new code.NavItem
component introduced within Create NavItem component #5972ThemeToggle
component introduced within feat(themeToggle): introduce #6007LanguageDropdown
component introduced within Component/language drop down #5982i18n/locales/en.json
file.components.headers.links.learn
Storybook
Add a storybook story file
components/sections/Navbar/index.stories.tsx
which exercises each of the component's states.There are 4 Navbar states to capture within styles and stories:
Light and dark modes toggle between https://github.com/nodejs/nodejs.org/blob/main/public/static/images/logos/horizontal-light.svg and https://github.com/nodejs/nodejs.org/blob/main/public/static/images/logos/horizontal-dark.svg. I imagine there is a way to do this with just a fill, but I didn't confirm.
Open Questions
site.json
? Today many are innavigation.json
but that's for the live site.The text was updated successfully, but these errors were encountered: