Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Navbar Component #6060

Closed
bmuenzenmeyer opened this issue Oct 28, 2023 · 8 comments · Fixed by #6072
Closed

Create Navbar Component #6060

bmuenzenmeyer opened this issue Oct 28, 2023 · 8 comments · Fixed by #6072
Labels
good first issue Issues for newcomers help wanted website redesign Issue/PR part of the Node.js Website Redesign

Comments

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Oct 28, 2023

Create a Navbar component using the new figma design (direct link).

This component starts the responsive header for the new site.

Read more about the Node.js Website redesign


Before You Start...


Details

image

Not sure where to start breaking down the figma? Read this short guide
🌐 This story requires some internationalization support. Slow down!

Storybook

Add a storybook story file components/sections/Navbar/index.stories.tsx which exercises each of the component's states.

There are 4 Navbar states to capture within styles and stories:

  • Light
  • Light, mobile
  • Dark
  • Dark, mobile

Light and dark modes toggle between https://github.com/nodejs/nodejs.org/blob/main/public/static/images/logos/horizontal-light.svg and https://github.com/nodejs/nodejs.org/blob/main/public/static/images/logos/horizontal-dark.svg. I imagine there is a way to do this with just a fill, but I didn't confirm.

Open Questions

  • Should the links be defined within site.json? Today many are in navigation.json but that's for the live site.
@bmuenzenmeyer bmuenzenmeyer added help wanted good first issue Issues for newcomers website redesign Issue/PR part of the Node.js Website Redesign hacktoberfest This Issue is meant for Hacktoberfest 2023 labels Oct 28, 2023
@bmuenzenmeyer bmuenzenmeyer moved this to 🔖 Ready in Website Redesign Oct 28, 2023
@bmuenzenmeyer
Copy link
Collaborator Author

Thanks for your interest. We don't assign tickets if we can help it. Feel free to submit a pull request if you have time.
Reference 🍪 https://www.redhat.com/en/blog/dont-lick-cookie

@bmuenzenmeyer
Copy link
Collaborator Author

Looks like we will be using navigation.json per #6064

@mirza-mohibul-hasan
Copy link

Is that work done?

@08Uzair
Copy link

08Uzair commented Oct 29, 2023

Please assign this to me i will do this work in 1-2 hrs

@Rounak-stha
Copy link
Contributor

There are 4 Footer states to capture within styles and stories:

Hey, I think you have a typo here. You probably meant to write Navbar right?

@bmuenzenmeyer
Copy link
Collaborator Author

Hey, I think you have a typo here. You probably meant to write Navbar right?

yes

@bmuenzenmeyer bmuenzenmeyer moved this from 🔖 Ready to 🏗 In progress in Website Redesign Nov 2, 2023
@bmuenzenmeyer bmuenzenmeyer linked a pull request Nov 2, 2023 that will close this issue
5 tasks
@bmuenzenmeyer bmuenzenmeyer moved this from 🏗 In progress to 👀 In review in Website Redesign Nov 2, 2023
@bmuenzenmeyer bmuenzenmeyer removed the hacktoberfest This Issue is meant for Hacktoberfest 2023 label Nov 2, 2023
@NIKHIL-bot27
Copy link

is this issue still open . Can you please assign me this issue

@ovflowd
Copy link
Member

ovflowd commented Nov 14, 2023

This issue already has an open PR which is already in review...

@bmuenzenmeyer bmuenzenmeyer moved this from 👀 In review to ✅ Done in Website Redesign Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues for newcomers help wanted website redesign Issue/PR part of the Node.js Website Redesign
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants