-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keccak256 preimage proof cannot be verified #1934
Comments
Is this ran with the experimental-ssa or the old ssa? cc @guipublic for visibility |
Just checked and passing |
@guipublic are there any blockers on diagnosing this issue? |
no, had to work around barretenberg but now I have a repro there and I am experimenting a fix. |
Update on this: @guipublic will create a unit test that is failing on the barretenberg side |
Fixed by AztecProtocol/barretenberg#632 |
This PR fixes noir issue 1934 (noir-lang/noir#1934): When using variable size keccak, the inputs that are after the provided length where not set to 0. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [X] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [X] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [X] Every change is related to the PR description. - [X] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
This PR fixes noir issue 1934 (noir-lang/noir#1934): When using variable size keccak, the inputs that are after the provided length where not set to 0. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [X] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [X] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [X] Every change is related to the PR description. - [X] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
The fix has now been integrated into noir with the last backend update. I am closing the issue. |
Aim
Generate and verify a proof for the program
with
Prover.toml
given byExpected Behavior
A proof may be generated and verified.
Bug
A proof may be generated but verification fails.
To Reproduce
main.nr
andProver.toml
with the above snippets.nargo prove p
.nargo verify p
.Installation Method
Compiled from source
Nargo Version
nargo 0.8.0 (git version hash: 1056ba1, is dirty: false)
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: