ACVM crate publishing is broken due to crates.io not taking Cargo.lock into account
#4384
Comments
Merged
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 15, 2024
…d using updated lockfile (#4385) # Description ## Problem\* Resolves #4384 ## Summary\* This PR resolves #4384 by updating the lockfile so that it's using the latest versions of the dependencies used by all of the ACVM packages and then runs the test suite against it to ensure that we still work correctly. ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: kevaundray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The most recent publish to crates.io failed: https://github.com/noir-lang/noir/actions/runs/7876962954/job/21492099000
The reasoning behind this is that people who install our crates don't use our lockfile but bring their own so Cargo ignores ours and attempts to build with the most recent versions of our dependencies as part of the publishing process. This then fails due to some of our dependencies bumping their MSRVs above ours which borks the publish.
Cargo also doesn't check just the dependencies which are relevant for the crate being published for but all dependencies in the entire workspace. TheThis paragraph seems to be incorrect.ahashdependency in the failing publish is only used innargo_clifor benchmarking but it blows up publishing anything from the workspace.See rust-lang/cargo#8728
The text was updated successfully, but these errors were encountered: