You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instruction::Truncate compiles down to a euclidean division where max_bit_size is passed in as the bit_size argument. The only place this is used in the circuit are
Where we're just specifying the types to be given to the brillig VM (where there's no difference between passing the real bit sizes and fake ones as long as they're big enough)
Brillig ignores max_bit_size entirely.
This raises the question of whether we just remove this field from Instruction::Truncate and pass in 254 as the bit size during ACIR gen.
The text was updated successfully, but these errors were encountered:
Instruction::Truncate
compiles down to a euclidean division wheremax_bit_size
is passed in as thebit_size
argument. The only place this is used in the circuit arenoir/compiler/noirc_evaluator/src/acir/acir_variable.rs
Lines 826 to 838 in 8d7f1f9
where we explicitly ignore this if the
rhs
term of the division is known at compile time (as is the case for truncations), also innoir/compiler/noirc_evaluator/src/acir/acir_variable.rs
Lines 845 to 846 in 8d7f1f9
Where we're just specifying the types to be given to the brillig VM (where there's no difference between passing the real bit sizes and fake ones as long as they're big enough)
Brillig ignores
max_bit_size
entirely.This raises the question of whether we just remove this field from
Instruction::Truncate
and pass in254
as the bit size during ACIR gen.The text was updated successfully, but these errors were encountered: