From 85e6950c24d04b89acd3b134cfb4831ff93be51c Mon Sep 17 00:00:00 2001 From: nolouch Date: Mon, 15 Apr 2024 16:47:43 +0800 Subject: [PATCH] address Signed-off-by: nolouch --- pkg/core/context.go | 2 +- pkg/ratelimit/runner.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/core/context.go b/pkg/core/context.go index d355488e516..ab149378b1d 100644 --- a/pkg/core/context.go +++ b/pkg/core/context.go @@ -29,7 +29,7 @@ type MetaProcessContext struct { } // NewMetaProcessContext creates a new MetaProcessContext. -// used in tests. +// used in tests, can be changed if no need to test concurrency. func ContextTODO() *MetaProcessContext { return &MetaProcessContext{ Context: context.TODO(), diff --git a/pkg/ratelimit/runner.go b/pkg/ratelimit/runner.go index f87ced11d5b..7f0ef21f791 100644 --- a/pkg/ratelimit/runner.go +++ b/pkg/ratelimit/runner.go @@ -85,7 +85,6 @@ func (s *ConcurrentRunner) Start() { if task.Opts.Limit != nil { token, err := task.Opts.Limit.Acquire(context.Background()) if err != nil { - log.Error("failed to acquire semaphore", zap.String("task-name", task.Opts.TaskName), zap.Error(err)) continue } go s.run(task.Ctx, task.f, token)