Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Props should not assume percentages #347

Open
mlenser opened this issue Feb 8, 2018 · 0 comments
Open

Props should not assume percentages #347

mlenser opened this issue Feb 8, 2018 · 0 comments

Comments

@mlenser
Copy link
Contributor

mlenser commented Feb 8, 2018

We have several props that assume percentages that can be unclear and potentially restrict the possible values.
Example:

width: props => `${props.width}${typeof props.width === 'number' ? '%' : ''}`,

These should probably pass in the expected value - though all downstream code will need to be updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant