You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
General issues with components that @RikardGehlin and I discovered while working on sketch:
Avatar has Icon as a child while Button and others use icon as a param
Dropdown should align with the click element. It should probably be renamed to something like Menu. See https://material-ui-next.com/demos/menus/ for an example of good behavior
hasSuccess vs modifier="success"
Consistent string params. Sometimes we use param={ 'value' }, other times param="value"
Logo should be combined with CostInfoLogo and SharevilleLogo
Instrument badge uses sm and md while buttons use xs, sm, md, and lg
Instrument badge defaults to md size while buttons default to sm
Icons should allow our default color sets (optionally allow special colors as well)??
Inputs should always reserve space below for error messages
Flag sizing should be xs, sm, md, and lg??
Flag should have a default size
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
General issues with components that @RikardGehlin and I discovered while working on sketch:
Avatar
hasIcon
as a child whileButton
and others use icon as a paramhasSuccess
vsmodifier="success"
param={ 'value' }
, other timesparam="value"
Logo
should be combined withCostInfoLogo
andSharevilleLogo
sm
andmd
while buttons usexs
,sm
,md
, andlg
md
size while buttons default tosm
xs
,sm
,md
, andlg
??The text was updated successfully, but these errors were encountered: