Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Inconsistencies #373

Open
mlenser opened this issue Mar 9, 2018 · 0 comments
Open

Inconsistencies #373

mlenser opened this issue Mar 9, 2018 · 0 comments

Comments

@mlenser
Copy link
Contributor

mlenser commented Mar 9, 2018

General issues with components that @RikardGehlin and I discovered while working on sketch:

  • Avatar has Icon as a child while Button and others use icon as a param
  • Dropdown should align with the click element. It should probably be renamed to something like Menu. See https://material-ui-next.com/demos/menus/ for an example of good behavior
  • hasSuccess vs modifier="success"
  • Consistent string params. Sometimes we use param={ 'value' }, other times param="value"
  • Logo should be combined with CostInfoLogo and SharevilleLogo
  • Instrument badge uses sm and md while buttons use xs, sm, md, and lg
  • Instrument badge defaults to md size while buttons default to sm
  • Icons should allow our default color sets (optionally allow special colors as well)??
  • Inputs should always reserve space below for error messages
  • Flag sizing should be xs, sm, md, and lg??
  • Flag should have a default size
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant