Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing highlight groups #11

Open
lunacookies opened this issue Mar 6, 2020 · 2 comments
Open

Missing highlight groups #11

lunacookies opened this issue Mar 6, 2020 · 2 comments

Comments

@lunacookies
Copy link

Xcode has added support for highlighting a few more items since the last update of the theme. The new highlight groups are ‘Heading’, ‘Type Declarations’, and ‘Other Declarations’. As the Nord theme currently does not define these, they take their colours from the default theme, which is quite jarring.

This is what Nord looks like when loaded into Xcode:

Screen Shot 2020-03-06 at 11 06 11 pm

Here is a screenshot showing the missing highlight groups:

Screen Shot 2020-03-06 at 11 09 19 pm

All the type and variable names in that saturated blue colour are using colours from the default theme.

Before Xcode added highlighting for these elements they were simply coloured the foreground colour. Is this ideal? Or is there a design decision to be made?

@arcticicestudio
Copy link
Contributor

Hi @arzg 👋, thanks for your contribution 👍
The new groups should be added to Nord to fix this highlighting. Classes and enums like CompassPoint should use nord7, functions like turnNorth() should be highlighted with nord8 and variables like resolution should use nord4.
To me the element name Heading sounds a bit like that it's only used for markup languages like Markdown, but I guess it requires some testing with different languages.

Feel free to submit a PR if you like to implement these new colors, otherwise I'll add it to the backlog to take a look at it later on 😄

@cntrump
Copy link

cntrump commented May 24, 2020

Heading color applied to markdown's codeblock.

I make a fork and set Heading to #D7737D

and SFMono-Medium is better than SFMono-Regular 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants