Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadTestsFromName conflicting #300

Open
yelite opened this issue Jul 9, 2016 · 1 comment
Open

loadTestsFromName conflicting #300

yelite opened this issue Jul 9, 2016 · 1 comment
Assignees

Comments

@yelite
Copy link

yelite commented Jul 9, 2016

Discovery plugin can handle folder/file names as testName.
But this event is consumed by other plugins first and event.loader.failedLoadTests(name, e) is returned because of ImportError.

If a plugin cannot handle this kind of event, it should just ignore it. And at the end if it's not handled by any plugins, failedLoadTests should be triggered by hook object or loader itself.

btw I am working on intellij/PyCharm integration. If nose2 can take file names as input, it will make the integration much easier.

@little-dude
Copy link
Contributor

If a plugin cannot handle this kind of event, it should just ignore it.

Plugins could check if the test name is a valid dotted name, and if not just ignore it? Why not. There are a bunch of issues with test loading (stacktraces being swallowed sometimes, making it difficult to see what's wrong) and it's pretty hacky, but I'm not sure how to fix it.

btw I am working on intellij/PyCharm integration.

Cool :) I think some people will be interested: #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants