Pull request to release #28157
JakeGinnivan
started this conversation in
Feature Requests
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The majority of my projects use https://github.com/changesets/action as the release process.
What this action does is if there planned changes (ie, file based versioning, and changeset markdown files in the changeset repo), it will open a 'Release' pull request, the description contains the unreleased changes all listed.
As more version plans are added, the PR just gets updated with the running to be released changes. Here is a screenshot
When the PR is merged, the action will see there are no planned changes (the PR updates the changelog.md, and version numbers in package.json files and deletes the planned files).
Because there are no changes it will run the
release
command instead of theversion
command. This releases the packages, creates github releases etc.Having the PR as a release trigger is great, because you can immediately see what are the unreleased changes in any repo.
A quick look into the release process of NX has the versioning step (merging the plan files into the changelog files and updating version numbers) is done within the release step.
The other reason having a pull request is great is for branch protections. The pull request for releasing contains all git changes, so the merge process updates all the files in git, then the release process creates the github release and publishes packages etc.
How could we have a similar setup with NX release?
Beta Was this translation helpful? Give feedback.
All reactions