Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALU_INC probably should not modify Carry Flag #2

Open
ecm-pushbx opened this issue Aug 5, 2021 · 1 comment
Open

ALU_INC probably should not modify Carry Flag #2

ecm-pushbx opened this issue Aug 5, 2021 · 1 comment

Comments

@ecm-pushbx
Copy link

when ALU_ADD | ALU_ADD_SE | ALU_ADC | ALU_ADC_SE | ALU_INC =>

Here and in the following lines we have a separate entry for ALU_DEC noting that it doesn't modify the Carry Flag. ALU_INC is grouped with the ALU_ADD operations though. Perhaps this means inc instructions modify Carry when they shouldn't.

@nsauzede
Copy link
Owner

nsauzede commented Aug 5, 2021

interesting !

Note that I'm not the author of this design, only a user of it in the past..
And indeed I had noticed some CF issues when trying to run some legacy code
Perhaps you pinpointed the rootcause(s) of it..

I should really set up a serious usecase showing the issue I had, and try and debug it with your suggestion

Unfortunately, I lack the free time for that... :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants