Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID not found for vain... #65

Open
himberjack opened this issue Jan 19, 2017 · 4 comments
Open

ID not found for vain... #65

himberjack opened this issue Jan 19, 2017 · 4 comments

Comments

@himberjack
Copy link

himberjack commented Jan 19, 2017

ID 2003562643204142 for instance claims to be not found. However after looking at the HTML, it doesnt have meta description tag as the code checks... maybe the validity of the existence of an asset should be checked other way.

@himberjack
Copy link
Author

Checking for 404 should be sufficient

@claudiofullscreen
Copy link

claudiofullscreen commented Jan 19, 2017 via email

@claudiofullscreen
Copy link

@himberjack The other PR was merged but this issue is still relevant.

In short, some videos don't have a <meta name="description".

What's a different way that we can use to check whether a Facebook URL is valid and matches a post?

@himberjack
Copy link
Author

It is a part of my PR. please see it. 404 should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants