Respect vim.o.shell

[adigitoleo]

Currently, this plugin always uses vim.env.SHELL as the default command. This behaviour is inconsistent with :terminal, which uses vim.o.shell. Using the latter value allows for more flexibility, since users can set the shell that they want neovim to use independently of the $SHELL used outside of nvim.

For example, on a shared system, I have $SHELL set to /bin/bash, but prefer to use $HOME/.local/bin/zsh for vim.o.shell.

Would it be reasonable to switch to using vim.o.shell by default?

[Vinni-Cedraz]

if I could at least make the default shell work I'd be happy. Currently it opens a window without anything not even a shell

[adigitoleo]

@Vinni-Cedraz If you are on NeoVim, I have since created my own plugin to handle floating terminals: haunt.nvim. It won't help for vim8 though, as it is written in lua.

[adigitoleo]

I have pushed a v2 of haunt.nvim which fixes a lot of things. But requires neovim 0.10. Will write a quick blog post about it with a video demo soon, and push a patch to try to restore support for 0.9.