Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a customer does not remove associated orders #3574

Open
nus-pe-bot opened this issue Apr 16, 2022 · 1 comment
Open

Deleting a customer does not remove associated orders #3574

nus-pe-bot opened this issue Apr 16, 2022 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 16, 2022

I'm not sure if this counts as a documentation bug or a functionality bug. However, deleting a customer in FoodOnWheels does not remove orders associated with that customer. This could lead to a build up of orders that have no customers or inconvenience users by forcing them to manually remove all orders for that customer. If there is reason for this behavior, it might be good to document under the corresponding UG section.


[original: nus-cs2103-AY2122S2/pe-interim#3566] [original labels: severity.Low type.FunctionalityBug]
@xzzz3
Copy link
Contributor

xzzz3 commented Apr 18, 2022

Team's Response

Hello tester, thank you for taking your time to test our app and providing this report! However, this is actually a discussed and considered behaviour of our FoodOnWheels app, that the customers' order should stay in the app after deleting the customers. Consider this: our app is targetted at restaurant delivery managers, and they are interested in how the delivery is doing overtime. If a customer called Aaron made a delivery order in the past, and the manager deleted Aaron (for space saving in the app, or due to accident), the order should remain as it contributes to the past revenue, which is an important statistic to help the restaurant. If the customers' orders are deleted with their deletion, this will result in detrimental loss of information that cannot be recovered, and even make the app unusable for users who like to clean up their interface often by deleting unused customers. This is also a very common practice in delivery that does not require further explanation (as mentioned above, it is so detrimental that it is basically fundamental for any delivery management app to have it).

Therefore, we propose rejecting this issue. Thanks!

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants