-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems in auto generated custom-completion files #258
Comments
Agreed. It was a quick first take at auto-generating custom completions from zsh completions (I believe). Feel free to help fix these. We wanted to land these, even though they weren't perfect, in the hope that someone else would come along and help polish them off. |
I'm happy to help fixing these. @fdncred Is the plan to manually correct the auto-generated scripts or only focus on correcting the generators? |
I'd prefer that the generators be fixed myself. so, when new ones are added to other system (zsh) we can just run the generator again and get accurate custom completions. what do you think? |
Yes, that would be the cleanest solution. With a good testing mechanism it will be the best option. However, in the interim allowing manual fixing of generated scripts may be good. |
ok, I'm down with whatever. there's a bunch of noop completions in here that need to be fixed too. |
Some auto generated custom-completion files have syntax errors.
As an example the
git.nu
has syntax errors in following locations:nu_scripts/custom-completions/auto-generate/completions/git.nu
Line 1 in 7d5c2f0
nu_scripts/custom-completions/auto-generate/completions/git.nu
Lines 785 to 789 in 7d5c2f0
nu_scripts/custom-completions/auto-generate/completions/git.nu
Line 1450 in 7d5c2f0
Related: #256 #257
The text was updated successfully, but these errors were encountered: