Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor]: stronger typed ManifestRockEntry.arch #62

Open
mrcjkb opened this issue Sep 14, 2024 · 0 comments
Open

[refactor]: stronger typed ManifestRockEntry.arch #62

mrcjkb opened this issue Sep 14, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mrcjkb
Copy link
Member

mrcjkb commented Sep 14, 2024

question: we'd probably benefit from making this an enum too, wouldn't we? Should this be given a TODO for the future? Note that the Triple type can be used to represent a "linux-arch" string quite nicely (with serialization and such).

Originally posted by @vhyrro in #61 (comment)
@mrcjkb mrcjkb mentioned this issue Sep 14, 2024
Merged
@vhyrro vhyrro added the enhancement New feature or request label Sep 15, 2024
@mrcjkb mrcjkb added the good first issue Good for newcomers label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrcjkb @vhyrro