Encoder: Intel ANV: fails with both H26x encoders

[dabrain34]

HasAllDeviceExtensions: ERROR: required device extension VK_KHR_video_maintenance1 is missing for device with name: Intel(R) Graphics (ADL GT2)
HasAllDeviceExtensions : WARNING: requested optional device extension VK_EXT_ycbcr_2plane_444_formats is missing for device with name: Intel(R) Graphics (ADL GT2)
ERROR: Found physical device with name: Intel(R) Graphics (ADL GT2), vendor ID: 8086, and device ID: 46a6 NOT having the required extensions!
vk-video-enc-test: /home/scerveau/DEV/IGALIA/PROJECTS/VALVE/DEV/vk_video_samples/vk_video_encoder/demos/vk-video-enc/Main.cpp:225: int main(int, char**): Assertion `!"Can't initialize the Vulkan physical device!"' failed.
Aborted (core dumped)

[dabrain34]

For H264, the default value for pRateControlInfo->rateControlMode is VK_VIDEO_ENCODE_RATE_CONTROL_MODE_VBR_BIT_KHR even if its VK_VIDEO_ENCODE_RATE_CONTROL_MODE_DEFAULT_KHR

See

vk_video_samples/vk_video_encoder/libs/VkVideoEncoder/VkEncoderConfigH264.cpp

Line 481 in 17d7b2d

if (rateControlMode == VK_VIDEO_ENCODE_RATE_CONTROL_MODE_DEFAULT_KHR) {

Is there a reason for that @zlatinski ?

For now ANV only supports DEFAULT or DISABLED

[dabrain34]

See #97

[zlatinski]

Hi Stephan, IIRC, we had a driver issue with VK_VIDEO_ENCODE_RATE_CONTROL_MODE_DEFAULT_KHR. We should have fixed that by now. Let me check, please.

[dabrain34]

As far as I can see the latest driver 77 did not fix the issue in DEFAULT mode.

[dabrain34]

Found out that the H264 encoder was failing because of inline query not properly supported.

Working on a patch here https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31765

H265 is still failing with:

vk-video-enc-test: /DEV/vk_video_samples/common/libs/VkCodecUtils/VulkanVideoSession.cpp:85: static VkResult VulkanVideoSession::Create(const VulkanDeviceContext*, VkVideoSessionCreateFlagsKHR, uint32_t, VkVideoCoreProfile*, VkFormat, const VkExtent2D&, VkFormat, uint32_t, uint32_t, VkSharedBaseObj<VulkanVideoSession>&): Assertion `videoSessionMemoryRequirementsCount <= MAX_BOUND_MEMORY' failed.

Need to investigate why