Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot build node gyp module for nwjs 0.39+ #7145

Closed
panther7 opened this issue Aug 28, 2019 · 7 comments
Closed

Cannot build node gyp module for nwjs 0.39+ #7145

panther7 opened this issue Aug 28, 2019 · 7 comments
Assignees
@rogerwang

Comments

@panther7
Copy link

panther7 commented Aug 28, 2019 •
edited
Loading

Hi, from Nwjs version 0.39 we can't builds sqlite3. This is critical stopper for releasing newer NWjs.

Issues:
@panther7
Copy link
Author

^ @rogerwang

@rogerwang rogerwang self-assigned this Sep 2, 2019
@rogerwang
Copy link
Member

This should share the same root cause with #7104

@panther7
Copy link
Author

panther7 commented Sep 3, 2019

Hm, and any progress fix this issue?

This is really stopper for use new nwjs with sqlite

@gpetrov
Copy link

gpetrov commented Sep 11, 2019

any progress @rogerwang ? We would really like to build or native node modules in NWJS 0.40+ - but are stuck now in 0.38 because of this problem

@panther7
Copy link
Author

panther7 commented Sep 18, 2019 •
edited
Loading

I think, some progress: nwjs/v8@bf62c46

@rogerwang
Copy link
Member

Fixed in #7104

@gpetrov
Copy link

gpetrov commented Nov 10, 2019

@rogerwang is this something we can also integrate? As compiled node modules are really fat now

electron/electron#20614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rogerwang @gpetrov @panther7