Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solid: Support nx v20 #1134

Closed
sudokar opened this issue Oct 13, 2024 · 13 comments
Closed

Solid: Support nx v20 #1134

sudokar opened this issue Oct 13, 2024 · 13 comments
Labels
feature request

Comments

@sudokar
Copy link

sudokar commented Oct 13, 2024

Is your feature request related to a problem? Please describe.

I have set up a new repo using Nx v20 along with @nxext/[email protected]. Upon running nx g @nxext/solid:app my-app getting the below error.

image

Describe the solution you'd like

I think, support for nx 20 is required to get this plugin working with Nx 20

Describe alternatives you've considered

Using Nx 19 until it is supported
@pawel-twardziak
Copy link
Contributor

@sudokar Are you willing to raise a PR for that? I am about to do it as I need it in my project - just let me know if you are going to do do it yourself.

@suds-sky
Copy link

@pawel-twardziak , Please feel free to 😄

@pawel-twardziak
Copy link
Contributor

pawel-twardziak commented Oct 13, 2024 •
edited
Loading

Ok @suds-sky , it is coming... 🚀 😆

pawel-twardziak added a commit to pawel-twardziak/nx-extensions that referenced this issue Oct 13, 2024
@pawel-twardziak
chore(solid): align package to nx 20
2e02633 
Closes nxext#1134

BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one
@pawel-twardziak
Copy link
Contributor

@DominikPieper I've just raised a PR with NX 20 migration + aligning solid package. I am proceeding the rest but maybe @sudokar @suds-sky wants us to bake https://www.npmjs.com/package/@nxext/solid ASAP?

pawel-twardziak added a commit to pawel-twardziak/nx-extensions that referenced this issue Oct 13, 2024
@pawel-twardziak
chore(solid): align package to nx 20
a67138e 
Closes nxext#1134

BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one
pawel-twardziak added a commit to pawel-twardziak/nx-extensions that referenced this issue Oct 13, 2024
@pawel-twardziak
chore(solid): align package to nx 20
73e2bfc 
Closes nxext#1134

BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one
pawel-twardziak added a commit to pawel-twardziak/nx-extensions that referenced this issue Oct 13, 2024
@pawel-twardziak
chore(preact): align package to nx 20
1cabb4a 
Closes nxext#1134

BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one
@pawel-twardziak
Copy link
Contributor

@suds-sky @sudokar done! 8 hour hackathon 🤣 to get this shit done 👯
@DominikPieper ready to CR 👍

@sudokar
Copy link
Author

sudokar commented Oct 13, 2024 •
edited
Loading

@suds-sky @sudokar done! 8 hour hackathon 🤣 to get this shit done 👯 @DominikPieper ready to CR 👍

Wow! Great work @pawel-twardziak. Thanks. I should have joined your hackathon 😄 I didn't think it would require a PR with 80 files changed ⭐

@pawel-twardziak
Copy link
Contributor

hehe @sudokar for your request there are only 2 commits with around 10 changed files 🤣 the rest changed files are related to the other packages. The migration is for the entire repo 😃

pawel-twardziak added a commit to pawel-twardziak/nx-extensions that referenced this issue Oct 13, 2024
@pawel-twardziak
chore(nxext): migrate workspace to nx 20
ef23bf1 
commit 6f7be4c
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 21:52:09 2024 +0200

    chore: make package deps ready for minor and patch changes

commit 2c378f4
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:42:22 2024 +0200

    chore(capacitor): align package to nx 20 - linting

commit 8a33e5b
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:39:00 2024 +0200

    chore(svelte): align package to nx 20

commit c888cfd
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:38:20 2024 +0200

    chore(capacitor): align package to nx 20

commit e5280d5
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:11:32 2024 +0200

    chore(ionic-react): align package to nx 20 - linting

commit 2d4cd98
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:11:15 2024 +0200

    chore(ionic-angular): align package to nx 20 - linting

commit 070cc6a
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:10:56 2024 +0200

    chore(common): align package to nx 20 - linting

commit 3c0a866
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:10:36 2024 +0200

    chore(capacitor): align package to nx 20 - linting

commit b37961a
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:08:27 2024 +0200

    chore(ionic-react): align package to nx 20

commit f6057ba
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:08:12 2024 +0200

    chore(ionic-angular): align package to nx 20

commit 5dc50c3
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:07:51 2024 +0200

    chore(ionic-react-e2e): align package to nx 20

commit b190e90
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:07:27 2024 +0200

    chore(ionic-angular-e2e): align package to nx 20

commit f47a081
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 20:06:17 2024 +0200

    chore(capacitor-e2e): align package to nx 20

commit ec32a6a
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 19:51:18 2024 +0200

    chore(sveltekit): align package to nx 20

commit 1823cfe
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 19:36:59 2024 +0200

    chore(stencil): align package to nx 20

    BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one

commit 1f0afa5
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 19:36:36 2024 +0200

    chore(solid): align package to nx 20

commit 284e00a
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 19:36:11 2024 +0200

    chore(preact): align package to nx 20

commit 1fafe96
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 18:32:43 2024 +0200

    chore(svelte): align package to nx 20

    BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one

commit 132093f
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 17:43:46 2024 +0200

    chore(preact): align package to nx 20

    BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one

commit 73e2bfc
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 15:51:05 2024 +0200

    chore(solid): align package to nx 20

    Closes nxext#1134

    BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one

commit 3dbd5da
Author: Paweł Twardziak <[email protected]>
Date:   Sun Oct 13 15:02:36 2024 +0200

    chore: migrate to nx 20

    BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one
pawel-twardziak added a commit to pawel-twardziak/nx-extensions that referenced this issue Oct 14, 2024
@pawel-twardziak
chore(nxext): migrate workspace to nx 20
b4ca04a 
Closes nxext#1134

BREAKING CHANGE: generator option 'name' is optional in favor of 'directory' one
@edbzn edbzn closed this as completed in b6104d2 Oct 14, 2024
@sudokar
Copy link
Author

sudokar commented Oct 14, 2024

Thanks @pawel-twardziak and @edbzn, for quickly getting this in 🚀

@pawel-twardziak
Copy link
Contributor

Not at all @sudokar 👍 now test it and tell us what are the next issues 😆

@sudokar
Copy link
Author

sudokar commented Oct 14, 2024

Not at all @sudokar 👍 now test it and tell us what are the next issues 😆

Have just tested it @pawel-twardziak and found that it is still giving me the same issue. Can you check your side and see what happens.

Steps to replicate:

bunx create-nx-workspace --pm bun
cd my-app
bun add @nxext/solid -d
nx g @nxext/solid:app solid-app

Deps:

nx: 20.0.0
@nxext/solid: 20.0.0

@pawel-twardziak
Copy link
Contributor

@sudokar sure thing, will check, thanks for reporting :)

@pawel-twardziak
Copy link
Contributor

@sudokar could open a new issue for that? I am investigating

@pawel-twardziak
Copy link
Contributor

Ok, I did it :D #1137 - let's follow up there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sudokar @suds-sky @pawel-twardziak