Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different package managers (npm/pnpm/cnpm) #64

Open
johannesschobel opened this issue Jan 18, 2021 · 2 comments
Open

Support different package managers (npm/pnpm/cnpm) #64

johannesschobel opened this issue Jan 18, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@johannesschobel
Copy link
Contributor

Dear @beeman ,

thank you very much for this awesome (!) boiler plate code for webbased applications. I really like it - been following you for some time and just stumbled upon these generators.

Expected Behavior

I noticed, that the commands within the executors require yarn. Same with the inserted scripts in the package.json file.
Can we make yarn optional? i.e., if i would like to use npm, scripts need to be rewritten (i.e., npm run x instead of yarn x)

Thank you very much for your time & help

@beeman beeman added the enhancement New feature or request label Jan 18, 2021
@beeman
Copy link
Member

beeman commented Jan 18, 2021

Hi @johannesschobel, thanks for kind words, and for taking the time to check out @nxpm/stack.

I'd love to give you a little context about the status of the project and it's future.

The state of this project is currently more or less proof of concept (which I think totally validated itself!). With this in mind, I took quite a few shortcuts to make that happen, picking yarn as the package manager of choice is one of them.

I'll be rebuilding @nxpm/stack using Nx 11 and in that new structure it should be much easier to add new features and options. However, for moving to Nx 11 I'm currently blocked on this issue, once that's fixed I can start migrating my stack.

Now with regards to this specific question: I'm definitely open to support other package managers, and if this change is added I want to make sure to not only support npm, but also make sure pnpm and cnpm work.

I'm happy to help you land a PR that adds this, but it might be smart to wait a little bit until it's running on Nx 11. Because whatever gets added to @nxpm/stack now, also needs to be migrated.

I hope this answers your question.

@beeman beeman changed the title Make YARN optional Support different package managers (npm/pnpm/cnpm) Jan 18, 2021
@johannesschobel
Copy link
Contributor Author

Dear @beeman ,

thank you very much for your very fast answer on this issue.
Good to hear, that you are planning to support other package manager as well. Maybe you could use the default package manager that is specified in the workspace.json (i believe!). Nrwl already has such a configuration flag - maybe there is an API for that as well?

Regarding the migration process:
Do you have an estimated timeframe for the migration? I know, that you are currently blocked by a nrwl issue, however, as far as i have seen, this only affects tests, right?

All the best and thanks for your time / effort on this

@beeman beeman added this to the After Nx 11 upgrade milestone Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants