New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite 5 manifest path #29

Open

stanislavprokopov opened this issue Nov 1, 2024 · 0 comments

stanislavprokopov commented Nov 1, 2024

craft-plugin-vite/src/services/VitePluginService.php

Line 93 in fbf1bc5

    
           $this->manifestPath = FileHelper::createUrl($bundle->sourcePath, self::MANIFEST_FILE_NAME);

manifest path has changed in Vite 5, so cannot simply use sourcePath to build path to the manifest.json

Maybe simply check if manifestPath is already set in service config then dont override it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment