Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor elliptic curve API #2011

Open
querolita opened this issue Feb 6, 2025 · 0 comments
Open

Refactor elliptic curve API #2011

querolita opened this issue Feb 6, 2025 · 0 comments

Comments

@querolita
Copy link
Member

          That would require a bigger change, but I would have used a more explicit name to understand which form of curve and which coordinates we're using.

createCurve -> createWeierstrassAffineCurve
createCurveTwisted -> createTwistedEdwardsAffineCurve

The space (i.e. affine vs projective) could be omitted as most of the time, in circuit, we use the affine coordinates.

Originally posted by @dannywillems in #1949 (comment)

@querolita querolita changed the title That would require a bigger change, but I would have used a more explicit name to understand which form of curve and which coordinates we're using. Refactor elliptic curve API Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant