From fb93432dee7d11f1c0baee3a61ccc87b69b04564 Mon Sep 17 00:00:00 2001 From: Coby Date: Mon, 14 Oct 2024 16:03:52 -0400 Subject: [PATCH 1/4] setting up codeowners for o1js --- CODEOWNERS | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index d878a07b61..7510537a5d 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1 +1,9 @@ -/src/lib/gadgets @o1-labs/crypto-eng-reviewers @mitschabaude +# All files require a review from @o1-labs/o1js-admins +* @o1-labs/o1js-admins + +# Changes to source code should be reviewed by exploration team and future zkapps team +/src/examples @o1-labs/exploration-team @o1-labs/future-zkapps +/src/lib @o1-labs/exploration-team @o1-labs/future-zkapps + +# Provable code should be reviewed by the crypto team +/src/lib/provable @o1-labs/crypto-eng-reviewers From e0e0599473f46edfa0b2f2498ffff47d712eaafc Mon Sep 17 00:00:00 2001 From: Coby Date: Mon, 14 Oct 2024 16:19:31 -0400 Subject: [PATCH 2/4] update ownership to always include admins --- CODEOWNERS | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 7510537a5d..1e5a06c1ad 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -2,8 +2,5 @@ * @o1-labs/o1js-admins # Changes to source code should be reviewed by exploration team and future zkapps team -/src/examples @o1-labs/exploration-team @o1-labs/future-zkapps -/src/lib @o1-labs/exploration-team @o1-labs/future-zkapps - -# Provable code should be reviewed by the crypto team -/src/lib/provable @o1-labs/crypto-eng-reviewers +/src/examples @o1-labs/o1js-admins @o1-labs/exploration-team @o1-labs/future-zkapps +/src/lib @o1-labs/o1js-admins @o1-labs/exploration-team @o1-labs/future-zkapps From 1a56b0a870c0e1c4c65b7483322cf5cfb66f0545 Mon Sep 17 00:00:00 2001 From: Coby Date: Tue, 15 Oct 2024 13:35:58 -0400 Subject: [PATCH 3/4] updating again --- CODEOWNERS | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 1e5a06c1ad..6b85256398 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,6 +1,13 @@ -# All files require a review from @o1-labs/o1js-admins +# By default, review is required by o1js-admins * @o1-labs/o1js-admins -# Changes to source code should be reviewed by exploration team and future zkapps team -/src/examples @o1-labs/o1js-admins @o1-labs/exploration-team @o1-labs/future-zkapps +# Changes to the following paths should be reviewed by o1js-admins, but we will tag current and future zkapps teams as well (incorrect use of codeowners) +# We are relying on good faith to wait for admin approval on these PRs +# Dangerous PRs that could release a new version, new consensus rules, or anything like that will necessarily touch more than `/src/lib`, so this is minimally risky /src/lib @o1-labs/o1js-admins @o1-labs/exploration-team @o1-labs/future-zkapps + +# Changes to the following paths can be safely owned by the current and future zkapps teams (correct use of codeowners) +/src/examples @o1-labs/exploration-team @o1-labs/future-zkapps +/src/lib/util @o1-labs/exploration-team @o1-labs/future-zkapps + + From 4e1f855f6314ace8e1c16929531d5ccb3e7f9876 Mon Sep 17 00:00:00 2001 From: Coby Date: Wed, 16 Oct 2024 09:39:30 -0400 Subject: [PATCH 4/4] simplify codeowners to bare bones --- CODEOWNERS | 6 ------ 1 file changed, 6 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 6b85256398..314078d563 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -5,9 +5,3 @@ # We are relying on good faith to wait for admin approval on these PRs # Dangerous PRs that could release a new version, new consensus rules, or anything like that will necessarily touch more than `/src/lib`, so this is minimally risky /src/lib @o1-labs/o1js-admins @o1-labs/exploration-team @o1-labs/future-zkapps - -# Changes to the following paths can be safely owned by the current and future zkapps teams (correct use of codeowners) -/src/examples @o1-labs/exploration-team @o1-labs/future-zkapps -/src/lib/util @o1-labs/exploration-team @o1-labs/future-zkapps - -