Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Opening the content preview also opens the contextual menu #283

Closed
JE-Amouel opened this issue May 16, 2024 · 6 comments · Fixed by #285
Closed

[BUG] Opening the content preview also opens the contextual menu #283

JE-Amouel opened this issue May 16, 2024 · 6 comments · Fixed by #285
Assignees
Labels
bug Something isn't working

Comments

@JE-Amouel
Copy link

Description

What is the bug?
open content preview also open contextual menu.

Problem Explanation

if i open content's preview, pano's contextual menu also appear.

The bug happens when ...
i try to open content's preview with the mouse cursor only.

Environment

  • GNOME Shell version: 46
  • Distro: fedoda
  • Distro version: 40

Screencast

Screencast_05_16_2024_11.01.16_AM.webm
@JE-Amouel JE-Amouel added the bug Something isn't working label May 16, 2024
@Malix-Labs
Copy link

If I'm not mistaken, Pano is not yet compatible with Gnome 46

@Totto16
Copy link
Collaborator

Totto16 commented May 20, 2024

If I'm not mistaken, Pano is not yet compatible with Gnome 46

It is compatible, just not yet on EGO 😓 see #271

@Totto16
Copy link
Collaborator

Totto16 commented May 20, 2024

Description

What is the bug? open content preview also open contextual menu.

Problem Explanation

if i open content's preview, pano's contextual menu also appear.

The bug happens when ... i try to open content's preview with the mouse cursor only.

Environment

* GNOME Shell version: 46

* Distro: fedoda

* Distro version: 40

Screencast

Screencast_05_16_2024_11.01.16_AM.webm

I noticed that too, but since I'm not here since the beginning, I always assumed, that that was intended like this, it looks really weird, when the panel is on the right, but if it's in the bottom it is alright. I sometimes use this feature, when I'm currently navigating with the mouse, instead of using the shortcut to open it. 🤷🏼‍♂️

@oae Was this intended like this, or not?

@Totto16 Totto16 changed the title [BUG] [BUG] Opening the content preview also opens the contextual menu May 20, 2024
@oae
Copy link
Owner

oae commented May 20, 2024

It seems like the below commit broke this function. Only the right click should open the popup menu.

2361af0#diff-5cedbb3beb837d1b671d8202c9dd333d301088645922f2a32ee7a82b1a69aebaL115-L125

@Totto16 Totto16 self-assigned this May 20, 2024
@Totto16 Totto16 linked a pull request May 20, 2024 that will close this issue
8 tasks
@Malix-Labs
Copy link

@Totto16

It is compatible, just not yet on EGO 😓

Nice to hear it's halfway there
I don't know what "EGO" is thought

Gnome 46 display a tooltip that says

This extension is incompatible with your current version of GNOME
Screenshot from 2024-05-20 13-42-30

@Totto16
Copy link
Collaborator

Totto16 commented May 20, 2024

@Totto16

It is compatible, just not yet on EGO 😓

Nice to hear it's halfway there I don't know what "EGO" is thought

Gnome 46 display a tooltip that says

This extension is incompatible with your current version of GNOME
Screenshot from 2024-05-20 13-42-30

EGO refers to https://extensions.gnome.org/

Yes, you need to compile it yourself atm unfortunately, see #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants