Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove the token when an invalid_request occurs #51

Open
ruipenso opened this issue Jun 3, 2015 · 2 comments
Open

Don't remove the token when an invalid_request occurs #51

ruipenso opened this issue Jun 3, 2015 · 2 comments

Comments

@ruipenso
Copy link
Member

ruipenso commented Jun 3, 2015

The invalid_request is only sent due to missing or invalid parameters which are programmatic errors and should not be checked in runtime.

https://github.com/seegno/angular-oauth2/blob/master/src/interceptors/oauth-interceptor.js#L20
@ruipenso ruipenso changed the title Don't remove the token when a invalid_request occurs Don't remove the token when an invalid_request occurs Jun 3, 2015
@Gp2mv3
Copy link

Gp2mv3 commented Aug 15, 2015

I also faced this issue. I think it's not useful to remove the token indeed.

@ruipenso
Copy link
Member Author

@Gp2mv3 Cool. Is good to know other developers shares the same opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ruipenso @Gp2mv3