Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed T cell hierarchy #2461

Closed
41 tasks done
nicolevasilevsky opened this issue Jun 26, 2017 · 9 comments
Closed
41 tasks done

Proposed T cell hierarchy #2461

nicolevasilevsky opened this issue Jun 26, 2017 · 9 comments

Comments

@nicolevasilevsky
Copy link
Member

nicolevasilevsky commented Jun 26, 2017

Per our conversation today on the phenotype editors call, we will prioritize creating a new hierarchy under HP_0002843 Abnormality of T cells

Current hierarchy:
(please add new term requests under existing terms as NTR: term (and use bold format)

@pnrobinson
Copy link
Contributor

We will need to consider carefully how to structure the hierarchy. Clinically, the following four T cell subsets are commonly encountered: naive, central memory, effector memory, and terminally differentiated effector memory cells re-expressing CD45RA (TEMRA). An analogous subhierarchy exists for CD4+ and CD8+ T cells. Different markers have been used at different times over the last decades, and we need to try to make our definition reflect current practice and to add old marker combinations as exact or related synonyms.

The following comes from http://onlinelibrary.wiley.com/doi/10.1002/cyto.a.22351/full

The surface markers typically used to define the four main sub-populations of T cells can be summarized as follows; N (CCR7+, CD27++, CD28++, CD45RA+), CM (CCR7+, CD27+++, CD28+++, CD45RA−), EM (CCR7−, CD27+/−, CD28+/−, CD45RA−) and TEMRA (CCR7−, CD27−, CD28−, CD45RA+)

@cmungall
Copy link
Member

Sorry mr broken record here...

I suggest you don't think about the hierarchy at all, just define using CL and let the reasoner do the work.

@pnrobinson
Copy link
Contributor

@nicolevasilevsky This label (Abnormal proportion of T cells) seems ambiguous because it does not say whether the proportion is say B cell vs T cell or whether the proportion refers to T cell subsets (which is what we want). I agree that the current label (Abnormal T cell subset distribution) is not easily grokk-able. Can we continue to brainstorm about what the optimal label should be though?

@pnrobinson
Copy link
Contributor

@cmungall @drseb I currently would be a bigger fan of letting the reasoner check our work and would like to see us make Seb's Q/C tool a part of the pipeline again. The raw CL hierarchy has lots of cells that are not really used in clinical workups and I think we need to do the first pass manually.

@mellybelly
Copy link
Member

we should be able to add a subset tag in CL to help this

@pnrobinson pnrobinson changed the title Proposed T cell hiearchy Proposed T cell hierarchy Sep 3, 2017
@cmungall
Copy link
Member

cmungall commented Dec 4, 2017

not sure a subset tag is necessary, it's not different from any other ontology. You simply use the cell types that you care about, the reasoner will still infer the correct results. The terms could be added in protege or incaform

@pnrobinson
Copy link
Contributor

Absent cellular immunity is being used to annotate only one disease, https://omim.org/entry/267500
It is referring to lack of T cell function. I am going to change the primary label.

@pnrobinson
Copy link
Contributor

The term Exaggerated cellular immune processes is inexact. It is being used to annotate one disease in our corpus. I am leaving it for now but it would be good to be more precise as to what is being observed. It may be that it was a positive Kveim test, but this test is no longer frequently used.

@pnrobinson
Copy link
Contributor

All of these terms have been processed, I am closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants