Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell type confirmation for HP_0005415 and HP_0031393 #5693

Closed
LCCarmody opened this issue May 11, 2020 · 4 comments
Closed

Cell type confirmation for HP_0005415 and HP_0031393 #5693

LCCarmody opened this issue May 11, 2020 · 4 comments

Comments

@LCCarmody
Copy link
Collaborator

HPO term

HP_0005415 | Decreased proportion of CD8-positive T cells| HP Text Def: A decreased proportion of circulating CD8-positive, alpha-beta T cells relative to total number of T cells.
-- | --
HP_0031393 | Abnormal proportion of CD8 T cells| HP Text Def: Any abnormality in the proportion of CD8 T cells relative to the total number of T cells.

Bug description

  1. Are these referring to the same cell type?
  2. Are these (one or both) referring to
CL:0000625 CD8-positive, alpha-beta T cell
?
  1. If these are the same cells, they are not in a parent child relationship. If they are the same, they need to be moved. If they aren't, it needs to be clearer which cell type each refers to and suggest additional terms (Abnormal, Increased, Decreased) as needed.

#4289

@nicolevasilevsky
Copy link
Member

  1. I think these are referring to the same cell type.

  2. I think the CL term is CL:0000625, as you said.

  • HP_0005415 Decreased proportion of CD8-positive T cells should be a child of HP_0031393 Abnormal proportion of CD8 T cells
  • we should rename HP_0031393 to Abnormal proportion of CD8-positive T cells

@LCCarmody
Copy link
Collaborator Author

I am confused. The label already uses Abnormal proportion of CD8 T cells, should it be changed Abnormal proportion of CD8-positive, alpha-beta T cells? Or should that be added as a synonym.

@nicolevasilevsky
Copy link
Member

I think my comment suggested changing it to Abnormal proportion of CD8-positive T cells

@pnrobinson
Copy link
Contributor

I would suggest we leave alpha-beta as default and just show it as a synonym -- otherwise the term names will be extremely long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants