Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle callbacks should be called in separate threads #147

Open
ChristopheCVB opened this issue Oct 23, 2022 · 1 comment
Open

Lifecycle callbacks should be called in separate threads #147

ChristopheCVB opened this issue Oct 23, 2022 · 1 comment
Labels
bug Something isn't working core good first issue Good for newcomers to specify

Comments

@ChristopheCVB
Copy link
Member

ChristopheCVB commented Oct 23, 2022

Describe the bug

Lifecycle callbacks should be called in separate threads

Code Sample

Simply add a Lifecycle callback when setting up the OBSRemoteController.

Expected behavior

In order to not to be blocked in our own thread, we should invoke callbacks in a separate thread.

Additional context

None.

@ChristopheCVB ChristopheCVB added bug Something isn't working core labels Oct 23, 2022
@ChristopheCVB ChristopheCVB added the good first issue Good for newcomers label Nov 9, 2022
@Blackn0va
Copy link

i need a change in the code here. The threads that are started from obswebsocket are never terminated, I can't terminate them in a hard way. This means that 24/7 stream bots will eventually run into the wall because there is no more memory available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core good first issue Good for newcomers to specify
Projects
None yet
Development

No branches or pull requests

2 participants