From 5b149add99e3f49909a5d0158a53abf68d8f2559 Mon Sep 17 00:00:00 2001 From: Norihiro Kamae Date: Mon, 8 May 2023 01:24:50 +0900 Subject: [PATCH] RequestHandler: Fix memory leak when setting streaming service --- src/requesthandler/RequestHandler_Config.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/requesthandler/RequestHandler_Config.cpp b/src/requesthandler/RequestHandler_Config.cpp index 2835a6b82..215306716 100644 --- a/src/requesthandler/RequestHandler_Config.cpp +++ b/src/requesthandler/RequestHandler_Config.cpp @@ -599,9 +599,9 @@ RequestResult RequestHandler::SetStreamServiceSettings(const Request &request) obs_service_update(currentStreamService, newStreamServiceSettings); } else { - // TODO: This leaks memory. I have no idea why. - OBSService newStreamService = obs_service_create(requestedStreamServiceType.c_str(), "obs_websocket_custom_service", - requestedStreamServiceSettings, nullptr); + OBSServiceAutoRelease newStreamService = obs_service_create(requestedStreamServiceType.c_str(), + "obs_websocket_custom_service", + requestedStreamServiceSettings, nullptr); // TODO: Check service type here, instead of relying on service creation to fail. if (!newStreamService) return RequestResult::Error(