Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video sound keeps playing after closing the popup it's in #1476

Closed
lauracumming opened this issue Aug 29, 2023 · 2 comments
Closed

Video sound keeps playing after closing the popup it's in #1476

lauracumming opened this issue Aug 29, 2023 · 2 comments
Assignees
@AbdelrahmanDeghedy
Labels
bug good first issue Good issue for first time contributor volunteers Tasks that can be picked up by anyone

Comments

@lauracumming
Copy link

lauracumming commented Aug 29, 2023 •
edited by faucomte97
Loading

Describe the bug
When the user plays a video in Rapid Router, whether or not logged in, and closes the pop-up without first stopping or pausing the video, the video continues to play and the user is left confused.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to a Rapid Router level with a video (eg, level 19)
  2. Start the video in the popup
  3. Close pop-up without stopping video
  4. See the joy that happens 😬

Expected behaviour
It should stop playing with pop-up closure

Screenshots
image
@lauracumming lauracumming added the volunteers Tasks that can be picked up by anyone label Oct 10, 2023
@faucomte97 faucomte97 added bug good first issue Good issue for first time contributor labels Dec 5, 2023
@faucomte97 faucomte97 changed the title Pop-up bug Video sound keeps playing after closing the popup it's in Dec 5, 2023
@AbdelrahmanDeghedy AbdelrahmanDeghedy mentioned this issue Dec 10, 2023
Merged
@AbdelrahmanDeghedy
Copy link
Contributor

Created an MR with a possible fix: #1554

@lauracumming
Copy link
Author

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbdelrahmanDeghedy AbdelrahmanDeghedy

Labels
bug good first issue Good issue for first time contributor volunteers Tasks that can be picked up by anyone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@faucomte97 @lauracumming @AbdelrahmanDeghedy