Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cows with pigeon in City theme #1674

Closed
4 tasks
faucomte97 opened this issue Jul 10, 2024 · 6 comments · Fixed by #1712
Closed
4 tasks

Replace cows with pigeon in City theme #1674

faucomte97 opened this issue Jul 10, 2024 · 6 comments · Fixed by #1712
Assignees
Labels
volunteers Tasks that can be picked up by anyone

Comments

@faucomte97
Copy link
Contributor

faucomte97 commented Jul 10, 2024

Task Description

Task 443 needs to be completed before this task can be started.

The level editor has cows that you can place on the road (and eventually, just around on the map).
The cows make sense in the Grass, Farm and Snow themes but not so much in the City theme - so we need to replace the cows with the pigeon.

Acceptance Criteria

  • When selecting the City theme, the cow should be replaced with the pigeon.
  • For the pigeons, play the sound file chosen for the pigeon when the van sounds the horn instead of the cow sound.
  • Rename the label from "Cows:" to "Pigeons:" when the City theme is selected.
  • The "cows" block needs to be updated, if possible, so that if the City theme is selected it reads "pigeons" and has the image of the pigeon instead. If not feasible, replace the block to say "animals" instead.

image

@lauracumming
Copy link

@evemartin could you attach the cow svg or eps here please? I can't locate it on our server.

@lauracumming
Copy link

Some inspiration:Screenshot 2024-07-31 at 09.44.41.png

Screenshot 2024-07-31 at 09.44.24.png

Screenshot 2024-07-31 at 09.44.16.png

@evemartin
Copy link
Contributor

Here is the cow svg! It is called Clarice.svg in the repo, maybe that's the name of the cow
Clarice

@faucomte97 faucomte97 changed the title Replace cows with city animal in City theme Replace cows with pigeon in City theme Aug 8, 2024
@faucomte97 faucomte97 added volunteers Tasks that can be picked up by anyone in2science labels Aug 8, 2024
@evemartin evemartin linked a pull request Aug 30, 2024 that will close this issue
@evemartin
Copy link
Contributor

This task is ready for review!

@github-project-automation github-project-automation bot moved this from Review/Waiting to Closed in Code for Life Kanban boards Sep 4, 2024
@lauracumming
Copy link

LGTM

@faucomte97 faucomte97 moved this from Staging to Production in Code for Life Kanban boards Sep 5, 2024
@faucomte97 faucomte97 reopened this Sep 5, 2024
@lauracumming
Copy link

LGTM

@github-project-automation github-project-automation bot moved this from Production to Closed in Code for Life Kanban boards Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
volunteers Tasks that can be picked up by anyone
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants