Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Experimental effect syntax support? #2559

Open
Zeta611 opened this issue Jun 22, 2024 · 2 comments
Open

Feature request: Experimental effect syntax support? #2559

Zeta611 opened this issue Jun 22, 2024 · 2 comments

Comments

@Zeta611
Copy link

Zeta611 commented Jun 22, 2024

I'm currently using 5.1.1+effect-syntax variant, and ocamlformat (obviously) fails to work.

Describe the solution you'd like
I have actually implemented a rudimentary support for the syntax here for personal use.

But I'm not sure whether or not or how I should contribute, as this is an experimental syntax support.

Additional context
It works:
Screenshot 2024-06-22 at 18 14 27

@Julow
Copy link
Collaborator

Julow commented Jun 26, 2024

This is awesome ! I think you can definitely open a PR as the effect syntax is to be released in OCaml 5.3 (I think?)

@Zeta611
Copy link
Author

Zeta611 commented Jun 26, 2024

Great, I've opened it in #2562!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants