Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose deriver for use by other derivers? #65

Open
apatil opened this issue Nov 13, 2017 · 1 comment
Open

Expose deriver for use by other derivers? #65

apatil opened this issue Nov 13, 2017 · 1 comment

Comments

@apatil
Copy link

apatil commented Nov 13, 2017

I'm working on a library, https://github.com/apatil/aplomb, that involves a ppx deriver. The deriver needs to emit to_yojson as well as a few other functions that are specific to my library.

Put another way, in the example in the https://github.com/apatil/aplomb/README.md, I currently have [@@deriving yojson,aplomb]. I'd like to shorten that to [@@deriving aplomb] but still have ppx_deriving_yojson generate to_yojson.

Would it make sense to expose ppx_deriving_yojson's deriver in the library so that derivers like mine can use and augment it, or is there an easier way to do what I want?

@whitequark I'd be happy to submit a patch if it makes sense, I see from other issues that you're crunched for time.

@whitequark
Copy link
Collaborator

I agree this is valuable. Please submit a patch. I'll review the overall architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants