Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce tests for new changes #105

Open
eltongarbin opened this issue Aug 7, 2021 · 0 comments
Open

Enforce tests for new changes #105

eltongarbin opened this issue Aug 7, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@eltongarbin
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We must consider tests when developing a library that supports other applications, because this brings some quality and facilitates new changes. So, I propose to configure this project to require 100% test coverage of what we are delivering.

Describe the solution you'd like

  • Configure local and CI to run tests.
  • Pull requests must be 100% changes coverage for merge.

Describe alternatives you've considered
https://about.codecov.io/blog/code-coverage-for-android-development-using-kotlin-jacoco-github-actions-and-codecov/

Additional context
You can take what we've made in this project as a reference:
https://github.com/ocean-ds/ocean-web/blob/master/.github/workflows/ci.yml

@eltongarbin eltongarbin added the enhancement New feature or request label Aug 7, 2021
@eltongarbin eltongarbin added this to the Q3 - 2021 milestone Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant