Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPS/SVCB Record support #47

Open
nefaspartim opened this issue Jul 30, 2024 · 2 comments
Open

HTTPS/SVCB Record support #47

nefaspartim opened this issue Jul 30, 2024 · 2 comments

Comments

@nefaspartim
Copy link

Hi all,

Just requesting support for HTTPS/SVCB records. I might take a stab at the development of this, but wanted to document it in an issue in case support was already in the works.
@nefaspartim
Copy link
Author

@ross - Almost complete here, just getting a coverage issue with isinstance. Do you care about #pragma no cover?

@ross
Copy link
Contributor

ross commented Aug 2, 2024

@ross - Almost complete here, just getting a coverage issue with isinstance. Do you care about #pragma no cover?

The #pragma no cover policy is roughly that it can only be used on blocks that are dealing with python or library versions, e.g. https://github.com/search?q=org%3Aoctodns+%22no+cover%22&type=code

If you're running into it otherwise the best option is probably to go ahead and push a branch up and open it as a draft PR so that I can 👁️ it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ross @nefaspartim