Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dump payload in dark mode #2

Open
willemvb opened this issue May 12, 2022 · 5 comments
Open

[BUG] Dump payload in dark mode #2

willemvb opened this issue May 12, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@willemvb
Copy link

willemvb commented May 12, 2022

Describe the bug

See spatie/ray#686
The Dump payload doesn't seem to render well in dark mode.

Not 100% sure, but I guess it's related to these styles: https://github.com/octoper/go-ray/blob/main/payloads/DumpPayload.go#L12-L19

To Reproduce

  • Switch to dark mode
  • Render an array
  • Notice the light text on light background

Expected behavior

  • Light text on dark background

Additional context

Instead of the inline styles, you might use the code CSS class we use in Ray to render code blocks to have a variable background.

@willemvb willemvb added the bug Something isn't working label May 12, 2022
@octoper
Copy link
Owner

octoper commented May 24, 2022

Hello @willemvb thank you for pointing it out, I will try to take a look in the upcoming days.

@acidjazz
Copy link

acidjazz commented Aug 6, 2022

Ran into this as well - a bit hard to read - wondering if theres a work around? @octoper

image

@acidjazz
Copy link

any advice on how i can maybe tackle this or any quick fix @octoper ?

@ghost
Copy link

ghost commented Sep 14, 2022

This is killing me

@octoper
Copy link
Owner

octoper commented Sep 14, 2022

Hello, haven't found time to check it, and I don't think I can for a couple more days.
The only think I can suggest if anyone wants to make a PR is add a prefers-color-scheme media query and change the background color and text color accordingly. You can see the styles here https://github.com/octoper/go-ray/blob/main/payloads/DumpPayload.go#L12-L19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants