Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: minify statically cached files #8

Open
lukeagsmith opened this issue Jul 22, 2021 · 4 comments
Open

FR: minify statically cached files #8

lukeagsmith opened this issue Jul 22, 2021 · 4 comments

Comments

@lukeagsmith
Copy link

The add-on is great, but when I turned static caching the html created was no-longer minified.

Is is possible to make the add-on work with static caching?

@octoper
Copy link
Owner

octoper commented Jul 23, 2021

I tried to reproduce the issue but I couldn't it's working fine for me.

@lukeagsmith
Copy link
Author

Thanks for coming back to me Vaggelis.

So for you, when you directly open the files that get written to the static folder, they are minified html?

@octoper
Copy link
Owner

octoper commented Aug 5, 2021

You are right they are not minified but when I'm browsing the page it is working just fine.
So I don't think thats a problem with the plugin but with Statamic I think it's applying the middleware after it's generating the static page.

@hlorofos
Copy link

It doesn't work for me either. Saved static files aren't minified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants