Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError on a PR with many commits #74

Open
thclark opened this issue Aug 4, 2022 · 2 comments
Open

TypeError on a PR with many commits #74

thclark opened this issue Aug 4, 2022 · 2 comments
Assignees
Labels
bug Unintended behaviour in any area of the app

Comments

@thclark
Copy link
Contributor

thclark commented Aug 4, 2022

Bug report

What is the current behaviour?

In this PR I have hundreds of commits.

I'm guessing that the number of commits is the problem, I'm not certain.

On running the update-pull-request action I get the following error:
Screenshot 2022-08-04 at 13 11 54

Perhaps over a certain number, the commit history is paginated meaning you don't get a string?

Note also that the stage where the error occurs is not the stage where it manifests: The error happens in the previous supposedly successful step

What is the expected behaviour?

  • The release notes compiler should exit with a non-zero code if it fails, so that the error is targeted to the right place
  • The release notes compiler should work with a long list of commits

To reproduce

Use either that particular PR, or take any repository with a long list of commits, look way back in the history, and check out a branch from there. Then make a PR from main into that branch and run the updater on it.

@thclark thclark added the bug Unintended behaviour in any area of the app label Aug 4, 2022
@thclark thclark moved this to Priority 1 (Low) in Octue Board Aug 4, 2022
@thclark
Copy link
Contributor Author

thclark commented Aug 4, 2022

Note: I've set this as a very low priority because it's unlikely to affect us often. It's more likely to hit people who use a trunk based development pattern (which I'm essentially doing in this particular case, due to a major overhaul).

@cortadocodes
Copy link
Member

@thclark has this happened again at all recently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended behaviour in any area of the app
Projects
Status: Priority 1 (Low)
Development

No branches or pull requests

2 participants