Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concordance Between Two Identical GLIMPSE2 Runs is Less Than 1 #252

Open
ethelvol21 opened this issue Jan 19, 2025 · 1 comment
Open

Concordance Between Two Identical GLIMPSE2 Runs is Less Than 1 #252

ethelvol21 opened this issue Jan 19, 2025 · 1 comment

Comments

@ethelvol21
Copy link

I observed that running the same GLIMPSE2 command twice with identical inputs and parameters does not yield perfect concordance (1.0) per sample. Despite using the same random seed, there are discrepancies in the results, as shown in the histogram below:

Histogram of Concordance (Chromosome 10):

Image

I used the following command twice:

GLIMPSE2_phase \
    --threads {cores_n} \
    --bam-list {files_list} \
    --reference {ref_file}_{chrom}_{regs}_{rege}.bin \
    --output {WORK_PATH}/chunks/phase/{output_file}_{chrom}_{regs}_{rege}.bcf \
    -F {ref_path}Homo_sapiens_assembly19.fasta \
    --seed 42

The concordance per sample is less than 1, despite the same random seed (--seed 42) being used for both runs.
Given the same random seed and identical input data, I expected the output to be deterministic and yield a concordance of 1.0 per sample.

Are there any specific settings or flags I should use to ensure deterministic output, or is there an inherent non-deterministic component in GLIMPSE2?

@srubinacci
Copy link
Collaborator

Hi,

Using multi-threading makes the output non deterministic, due to random invocation of the RNG. Running the same command on a single thread should solve your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants