Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simulation part in next release? #119

Open
joroeder opened this issue Apr 18, 2023 · 1 comment
Open

Remove simulation part in next release? #119

joroeder opened this issue Apr 18, 2023 · 1 comment

Comments

@joroeder
Copy link
Member

I noticed that some tests of the simulation parted do not properly test.

I am wondering how to proceed with the simulation part at all. There are better open source tools for thermo-hydraulic simulation (e.g. pandapipes). Should we remove the simulation part, as there is no active development here in DHNx anymore? This makes maintenance of the rest much easier, as we do not need to update unused tests and code anymore. Furthermore, it could be helpful if the DHNx repo focuses on the optimisation part for new users and further development, and new users and developers are not confused by the different parts (simulation / optimisation).

What do you think? @jnnr

@gitfeldhase
Copy link

I think it is a good idea, I used the simulation part and it was not that easy to create reasonable results (as a new user).
A wrapper which could create a pandapipes model based on the optimization model would be a great extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants