Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo broken #152

Open
cyrilbornet opened this issue Apr 23, 2014 · 3 comments
Open

Demo broken #152

cyrilbornet opened this issue Apr 23, 2014 · 3 comments

Comments

@cyrilbornet
Copy link

Hi,
The demo of oerpub that comes with this bundle is broken.
From what I've seen, just adding the "oer/figure" plugin declaration in /Aloha-Editor/oerpub/index.html line 79 should fix it... Could someone confirm this?
Yours,

@izak
Copy link

izak commented Apr 23, 2014

On Wed, Apr 23, 2014 at 6:12 PM, Cyril Bornet [email protected]:

Hi,
The demo of oerpub that comes with this bundle is broken.
From what I've seen, just adding the "oer/figure" plugin declaration in
/Aloha-Editor/oerpub/index.html line 79 should fix it... Could someone
confirm this?

Yes, github deprecated the master_branch attribute in one of the json
responses. It needs to be replaced with default_branch. The fix is already
in upstream, but the demo hasn't been updated yet.

@dagilleland
Copy link

More specifically, for those who are doing the manual fix and are not as sure what to do, here's the affected block of code in the /Aloha-Editor/oerpub/index.html file with the fix applied (adding oer/figure, at or after line 79).

            <script type="text/javascript" src="../src/lib/aloha.js"
                    tal:attributes="src string:${request.application_url}/aloha/src/lib/aloha.js"
                data-aloha-plugins="common/ui,
                                    oer/copy,
                                    oer/toolbar,
                                    oer/overlay,
                                    oer/format,
                                    common/contenthandler,
                                    common/paste,
                                    common/block,
                                    common/list,
                                    oer/table,
                                    oer/math,
                                    oer/mathcheatsheet,
                                    extra/draganddropfiles,
                                    common/image,
                                    oer/assorted,
                                    oer/figure,
                                    oer/title,
                                    common/undo,
                                    oer/undobutton,
                                    oer/genericbutton,
                                    oer/semanticblock,
                                    oer/exercise,
                                    oer/quotation,
                                    oer/equation,
                                    oer/example,
                                    oer/note"> <!-- xhtml workaround --></script>

@kathi-fletcher
Copy link
Member

Cyril,

We are having a bug fix sprint June 5-7th and I will put this in the bucket
if it doesn't get fixed before then. The sprint will be developers in
Houston with Connexions, OERPUB, and a developer from Siyavula attending
remotely. Would you like to participate for some portion? I realize this is
a comment on a github issue, but that is OK to since anyone else lurking
would be welcome also. : - )

Kathi

On Mon, May 26, 2014 at 1:28 PM, dagilleland [email protected]:

More specifically, for those who are doing the manual fix and are not as
sure what to do, here's the affected block of code in the
/Aloha-Editor/oerpub/index.html file with the fix applied (adding
oer/figure, at or after line 79).

        <script type="text/javascript" src="../src/lib/aloha.js"
                tal:attributes="src string:${request.application_url}/aloha/src/lib/aloha.js"
            data-aloha-plugins="common/ui,                                    oer/copy,                                    oer/toolbar,                                    oer/overlay,                                    oer/format,                                    common/contenthandler,                                    common/paste,                                    common/block,                                    common/list,                                    oer/table,                                    oer/math,                                    oer/mathcheatsheet,                                    extra/draganddropfiles,                                    common/image,                                    oer/assorted,                                    oer/figure,                                    oer/title,                                    common/undo,                                    oer/undobutton,                                    oer/genericbutton,                                    oer/semanticblock,                                    oer/exercise,                                    oer/quotation,                                    oer/equation,                                    oer/example,                                    oer/note"> <!-- xhtml workaround --></script>

Reply to this email directly or view it on GitHubhttps://github.com//issues/152#issuecomment-44209474
.

Katherine Fletcher, [email protected]
[email protected]
Twitter: kefletcher http://www.twitter.com/kefletcher Blog:
kefletcher.blogspot.com
[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants