Missing migration for the daily round model update

[Bhavik-ag]

Problem

• Missing migration for the daily round model update done in 2e12108

[rithviknishad]

@sainak should we add a CI to test if any migrations are missing in the future?

[rithviknishad]

cc: @vigneshhari

[sainak]

There is a precommit hook for it
We can add that as well

[Ashesh3]

There is a precommit hook for it
We can add that as well

Do we already have that? I already have precommit hooks installed and I don't remember seeing any such error when missing the migration..

[rithviknishad]

I think he meant that "there is a pre-commit hook that can be configured"

[rithviknishad]

@sainak I tried running a local pre-commit to run ./manage.py makemigrations --check --dry-run

This works fine when running via CLI (git commit -m ...), but fails to run when commiting from vscode git extension. Failed to import Django.

[Ashesh3]

@sainak I tried running a local pre-commit to run ./manage.py makemigrations --check --dry-run

This works fine when running via CLI (git commit -m ...), but fails to run when commiting from vscode git extension. Failed to import Django.

Does the vscode git command run outside the context of the current virtual environment, hence the failing import?

[rithviknishad]

it has got something to do with this actually

[sainak]

@sainak I tried running a local pre-commit to run ./manage.py makemigrations --check --dry-run

This works fine when running via CLI (git commit -m ...), but fails to run when commiting from vscode git extension. Failed to import Django.

Does the vscode git command run outside the context of the current virtual environment, hence the failing import?

Yes precommit creates virtual env for each hook and uses that by default
If you want to run checks with local packages use the system type for hooks