Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign create asset modal #7341

Closed
Sagarjari01 opened this issue Mar 5, 2024 · 6 comments
Closed

Redesign create asset modal #7341

Sagarjari01 opened this issue Mar 5, 2024 · 6 comments
Assignees

Comments

@Sagarjari01
Copy link

Sagarjari01 commented Mar 5, 2024

Describe the bug
The current UI for the Create Assets modal has some CSS overflow issues. We can redesign the whole modal, like the tailwind CSS search, and make a reusable component to use across the app.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Assets.
  2. Click on the Create Asset button.
  3. Type any letter.
  4. A scrollbar will appear on the whole page while a suggestion appears.

Bug 
https://github.com/coronasafe/care_fe/assets/70434968/a435fdf4-c3ff-432b-95ea-1b6d0f77f21e

Expected behavior
https://github.com/coronasafe/care_fe/assets/70434968/d34304db-ad00-462b-84a0-91661a935a85

@rithviknishad
Copy link
Member

@Sagarjari01 make it as a reusable component under CareUI so that it can be used in other places.

@Thanush19
Copy link

hey @rithviknishad , if the issue is not resolved , i can fix this....

@Sagarjari01 Sagarjari01 removed their assignment Mar 18, 2024
@kshitijv256
Copy link
Contributor

I can work on this issue

@MjStar24
Copy link

hey @rithviknishad I would work on this can you assign this to me

@MjStar24
Copy link

MjStar24 commented Mar 21, 2024

Hi @rithviknishad, I have a few questions. I'm aiming to create a reusable dialogue box similar to the one demonstrated in the video. Could you provide more details on what exactly I need to develop?

@MjStar24
Copy link

Hi @rithviknishad, I've addressed the CSS overflow problem and transformed it into a reusable component.
Could you review it and suggest any necessary changes?

Recording.2024-03-24.1230381.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
5 participants