Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualification field for nurse user type #8302

Closed
3 tasks
samholics opened this issue Aug 13, 2024 · 13 comments · Fixed by #8694
Closed
3 tasks

Qualification field for nurse user type #8302

samholics opened this issue Aug 13, 2024 · 13 comments · Fixed by #8694
Assignees
Labels

Comments

@samholics
Copy link

samholics commented Aug 13, 2024

Is your feature request related to a problem? Please describe.
Nurses may be of various types based on qualification. Capturing and showing this in CARE is helpful.

Proposed Solution

@aparnacoronasafe aparnacoronasafe added good first issue Good for newcomers blocked and removed blocked labels Aug 14, 2024
@ayushpatil2122
Copy link

hey i want to work on this issue
can you assign this issue to me

@gigincg
Copy link
Member

gigincg commented Aug 22, 2024

@ayushpatil2122 Please add an explanation on how you'll be implementing a solution

@github-actions github-actions bot added the stale label Sep 9, 2024
@aparnacoronasafe
Copy link
Member

@nihal467 Could you please follow up and move this ?

@AdityaJ2305
Copy link
Contributor

Hey @aparnacoronasafe @gigincg, could you please assign this issue to me if it's still available?

I've almost finished the task. The payload now successfully sends the nurse_qualification key to the backend, and the qualification field is displaying properly in the user edit view for nurses. Until the backend updates the users list, the nurse qualification is showing as 'unknown,' similar to how it works for doctor qualifications.

Screenshots for reference:
Screenshot 2024-09-29 at 6:17 PM
Screenshot 2024-09-29 at 6:18 PM
Screenshot 2024-09-29 at 6 23 39 PM

@ayushpatil2122 ayushpatil2122 removed their assignment Sep 29, 2024
@rithviknishad
Copy link
Member

We already have a qualification field named doctor_qualification. Should we consider renaming the field to qualification instead of using it?

cc: @gigincg

@AdityaJ2305
Copy link
Contributor

@rithviknishad, I’m not certain if I’m allowed to comment on this, but since we’re already sending doctor_qualification: undefined for other user types, it might be better to update it to qualification field instead of creating a new key like nurse_qualification. We can set the relevant values for both doctors and nurses while keeping it undefined for other user types. This approach would minimize backend changes.
Screenshot 2024-09-30 at 11 08 13 AM

@rithviknishad
Copy link
Member

Yes, let's proceed with:

  1. Rename the field in the backend to qualification
  2. Update the FE as per the requirements mentioned in the issue.

@AdityaJ2305
Copy link
Contributor

Understood! I'll update the frontend as per the issue. For the backend, I'll create a new issue to track the renaming of the field to qualification and handle the update accordingly. Let me know if there's anything else I should consider.

@rithviknishad
Copy link
Member

Just confirming, would you be creating the backend PR also?

@AdityaJ2305
Copy link
Contributor

I have limited experience with Django and Python, but I’m willing to create the backend PR. Any guidance from the maintainers would be appreciated!

@rithviknishad
Copy link
Member

You can start by renaming instances of "doctor_qualification" with "qualification" in the backend repo (except for the ones that are in the existing migrations).

And then you can run the makemigrations command to generate the RenameField DB schema migration which django generates for you automatically.

References:

@AdityaJ2305
Copy link
Contributor

Backend issue created for the same here

@rithviknishad
Copy link
Member

Here's the backend: ohcnetwork/care#2514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
6 participants