Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/specialized-error-handling #33

Open
quinnwai opened this issue Mar 7, 2024 · 1 comment
Open

feature/specialized-error-handling #33

quinnwai opened this issue Mar 7, 2024 · 1 comment
Labels
dev refactoring, testing, non-breaking code changes enhancement New feature or request

Comments

@quinnwai
Copy link
Member

quinnwai commented Mar 7, 2024

When we create VRS IDs or query metakb, we need to have error handling that describes the problem (network error, translation error, no matches found, etc). In some cases like within annotate_all, there can be non-descript messages outputted in the command line.

image

is it good enough for an error? Do we just have to redirect them to the logs file everytime?

@quinnwai quinnwai mentioned this issue Mar 7, 2024
@quinnwai quinnwai added the enhancement New feature or request label Mar 12, 2024
@quinnwai
Copy link
Member Author

quinnwai commented Apr 9, 2024

Still might need more work, as some logs can be misleading and we may want to suppress them: below the main problem is that the validation error is occurring but the traceback mentions a "timestamp_str" KeyError.

image

@quinnwai quinnwai changed the title feature/error-handling feature/specialized-error-handling Apr 9, 2024
@quinnwai quinnwai added the dev refactoring, testing, non-breaking code changes label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev refactoring, testing, non-breaking code changes enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant