Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Dummy Detection Dataset #69

Closed
3 tasks done
oke-aditya opened this issue Dec 3, 2020 · 0 comments · Fixed by #79
Closed
3 tasks done

Enhance Dummy Detection Dataset #69

oke-aditya opened this issue Dec 3, 2020 · 0 comments · Fixed by #79
Labels
datasets Providing Datasets to users good first issue Good for newcomers Medium Priority Should be addressed in few days

Comments

@oke-aditya
Copy link
Owner

oke-aditya commented Dec 3, 2020 •
edited
Loading

🚀 Feature

Add options to normalize and start classes from 0 or 1.

Motivation

Since we support YOLO format, some models such as Detr take normalized YOLO.
We should normalize the boxes w.r.t image dimensions (images are already normalized in T.ToTensor())
We should normalize data.
Some models start classes from 1 (FRCNN, etc) some start from 0 (Detr, lets support that)

Pitch

  • Add normalize: bool = False parameter.
  • Add class_start: int = 0 parameter.
  • Update detection tests and make them pass.

Additional context

Good first and Easy issue. After this and tests for this we can #20 make this public.
@oke-aditya oke-aditya added good first issue Good for newcomers Medium Priority Should be addressed in few days datasets Providing Datasets to users labels Dec 3, 2020
@oke-aditya oke-aditya mentioned this issue Dec 7, 2020
Merged
@oke-aditya oke-aditya linked a pull request Dec 7, 2020 that will close this issue
Update dummy detection dataset #78
Merged
@oke-aditya oke-aditya removed a link to a pull request Dec 7, 2020
Update dummy detection dataset #78
Merged
@oke-aditya oke-aditya linked a pull request Dec 7, 2020 that will close this issue
Refactor test for detection #79
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datasets Providing Datasets to users good first issue Good for newcomers Medium Priority Should be addressed in few days
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor test for detection
1 participant
@oke-aditya