Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move project to php-webdriver/MinkPhpWebDriver #4

Closed
andrewnicols opened this issue Jun 16, 2020 · 7 comments
Closed

Move project to php-webdriver/MinkPhpWebDriver #4

andrewnicols opened this issue Jun 16, 2020 · 7 comments

Comments

@andrewnicols
Copy link
Contributor

When @OndraM moved the php-webdriver from facebook/php-webdriver to php-webdriver/php-webdriver there was some discussion about the naming of the project there in relation to other projects (php-webdriver/php-webdriver#730 (comment)_).

To improve the sustainability of this project I feel that it might be worth moving it to be under the php-webdriver organisation. Ideally we should also update the namespace (sorry @oleg-andreyev).

Another alternative would be to move it under the MinkPHP project (@stof), but I feel that it makes more sense to link the Mink driver to the underlying Webdriver implementation than to the Mink project itself.

andrewnicols added a commit to andrewnicols/moodle-behat-extension that referenced this issue Jun 16, 2020
This is currently using oleg-andreyev/MinkPhpWebDriver but I have raised
oleg-andreyev/MinkPhpWebDriver#4 to look at
moving the project to php-wbdriver/MinkPhpWebDriver and trying to push
it as the authoritative Mink driver.
@oleg-andreyev
Copy link
Owner

@andrewnicols thanks for bringing this up. I understand and agree that this project has more chances to be recognized by the php-webdriver organization, and it will ensure that project won't be abandon.

Initially, I wanted to update Selenium2Driver (minkphp/MinkSelenium2Driver#304) to use php-webdriver, and IIRC there was a discussion about renaming the package, I tried to push Selenium2Driver forward, but I don't have access to merge PRs, but I got sick of slow responses...

I would like to hear something from @OndraM and @stof as they have more experience in OSS and maintaining OSS packages.

@andrewnicols
Copy link
Contributor Author

andrewnicols commented Jun 17, 2020 via email

@andrewnicols
Copy link
Contributor Author

Any chance we can move this forward? I feel that we should try and do this, and update PHP namespace etc. sooner rather than later.

@oleg-andreyev
Copy link
Owner

@andrewnicols the only reason why it's not yet done:

  • I haven't got any response from @stof or @OndraM
  • I'll lose maintainers access to the repository if I'll move it without a response from @stof or @OndraM

@OndraM
Copy link

OndraM commented Aug 6, 2020

Hi, sorry for the delay, I was on summer vacation :).

My first idea would by to try to use existing "minkphp" organization - from continuity reasons (as it already hosts drivers for Goutte, BrowserKite etc.) and discoverability (people will probably look for the driver on the same place as they found mink itself) . Do you have a response from @stof? But if you fell this won't work or there is no response/negative response from him, we may try going ahead with php-webdriver organization, I'm not strictly against it. But minkphp makes more sense me in context of the Mink project.

@oleg-andreyev
Copy link
Owner

As another solution is get into contacts with https://github.com/FriendsOfBehat they already have some forks for Mink.

andrewnicols added a commit to andrewnicols/moodle-behat-extension that referenced this issue Dec 4, 2020
This is currently using oleg-andreyev/MinkPhpWebDriver but I have raised
oleg-andreyev/MinkPhpWebDriver#4 to look at
moving the project to php-wbdriver/MinkPhpWebDriver and trying to push
it as the authoritative Mink driver.
andrewnicols added a commit to andrewnicols/moodle-behat-extension that referenced this issue Dec 4, 2020
This is currently using oleg-andreyev/MinkPhpWebDriver but I have raised
oleg-andreyev/MinkPhpWebDriver#4 to look at
moving the project to php-wbdriver/MinkPhpWebDriver and trying to push
it as the authoritative Mink driver.
andrewnicols added a commit to andrewnicols/moodle-behat-extension that referenced this issue Dec 6, 2020
This is currently using oleg-andreyev/MinkPhpWebDriver but I have raised
oleg-andreyev/MinkPhpWebDriver#4 to look at
moving the project to php-wbdriver/MinkPhpWebDriver and trying to push
it as the authoritative Mink driver.
andrewnicols added a commit to andrewnicols/moodle-behat-extension that referenced this issue Dec 7, 2020
This is currently using oleg-andreyev/MinkPhpWebDriver but I have raised
oleg-andreyev/MinkPhpWebDriver#4 to look at
moving the project to php-wbdriver/MinkPhpWebDriver and trying to push
it as the authoritative Mink driver.
@andrewnicols
Copy link
Contributor Author

Yeah - I'm thinking either just release under your repo, or FoB.

Either way, I think we're close to ready.

I've had a bit of time to spend on this over the past three weeks and have most of our steps passing cleanly now. I have a few random fails to hunt down but otherwise I think I've found most of the problems.

I'm currently applying the following Pull requests for all of our runs:

andrewnicols added a commit to andrewnicols/moodle-behat-extension that referenced this issue Dec 22, 2020
This is currently using oleg-andreyev/MinkPhpWebDriver but I have raised
oleg-andreyev/MinkPhpWebDriver#4 to look at
moving the project to php-wbdriver/MinkPhpWebDriver and trying to push
it as the authoritative Mink driver.
andrewnicols added a commit to andrewnicols/moodle-behat-extension that referenced this issue Dec 22, 2020
This is currently using oleg-andreyev/MinkPhpWebDriver but I have raised
oleg-andreyev/MinkPhpWebDriver#4 to look at
moving the project to php-wbdriver/MinkPhpWebDriver and trying to push
it as the authoritative Mink driver.
andrewnicols added a commit to andrewnicols/moodle-behat-extension that referenced this issue Dec 22, 2020
This is currently using oleg-andreyev/MinkPhpWebDriver but I have raised
oleg-andreyev/MinkPhpWebDriver#4 to look at
moving the project to php-wbdriver/MinkPhpWebDriver and trying to push
it as the authoritative Mink driver.
andrewnicols added a commit to andrewnicols/moodle-behat-extension that referenced this issue Dec 22, 2020
This is currently using oleg-andreyev/MinkPhpWebDriver but I have raised
oleg-andreyev/MinkPhpWebDriver#4 to look at
moving the project to php-wbdriver/MinkPhpWebDriver and trying to push
it as the authoritative Mink driver.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants