Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to websockets in ghcjs-base? #1

Open
ariep opened this issue Nov 5, 2015 · 1 comment
Open

Update to websockets in ghcjs-base? #1

ariep opened this issue Nov 5, 2015 · 1 comment

Comments

@ariep
Copy link

ariep commented Nov 5, 2015

Hi!

This package depends on ghcjs-websockets, which does not compile under newest ghcjs: mstksg/ghcjs-websockets#9. Among other changes, ghcjs-base now includes a Websocket module: https://github.com/ghcjs/ghcjs-base/blob/4b8ad4ebc95b77f1e89181bdd57101535182e810/JavaScript/Web/WebSocket.hs.

Do you think it is feasible to drop the dependency on ghcjs-websockets, and reimplement on top of the ghcjs-base version? It seems that the callback-type interface is suited to building a reflex-layer on top of it.

@oliver-batchelor
Copy link
Owner

Yeah, I think that might be a reasonable idea. Only trouble is that reflex-dom doesn't support the latest ghcjs-dom either!

Though there's the 'hamishmack' branch which does - and yes, I agree the more basic callback interface seems better for fitting in with reflex's Event lazy subscription.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants